Skip to content

Initialize ESPProvisioningProvider with the proper realm (from URL or…#56

Merged
ebariaux merged 5 commits into
mainfrom
fix/provision-provider-realm-api-url
May 27, 2026
Merged

Initialize ESPProvisioningProvider with the proper realm (from URL or…#56
ebariaux merged 5 commits into
mainfrom
fix/provision-provider-realm-api-url

Conversation

@ebariaux
Copy link
Copy Markdown
Contributor

@ebariaux ebariaux commented May 26, 2026

… preferences)

@ebariaux ebariaux added the Bug Something isn't working label May 26, 2026
@ebariaux ebariaux linked an issue May 26, 2026 that may be closed by this pull request
Use proper realm when building URL for Provisioning Provider #55
Closed
MartinaeyNL
MartinaeyNL requested changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MartinaeyNL MartinaeyNL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebariaux Me and @dominiquekleeven discussed on this "constants" approach, but agreed to not to go for this. 😅

My opinion was that the ESPProvisionProvider itself shouldn't be "aware that realms exist".
Instead, by including the realm in the provisionDevice payload itself, similar to the accessToken,
we only make the provider "realm aware" for this single API request the provider makes.

Alongside that, I think it'd be important for apps to work in multiple realms.
Because now it is locked into a single realm per app.

I'm happy to call if you'd like to discuss.

@ebariaux
Copy link
Copy Markdown
Contributor Author

ebariaux commented May 27, 2026

@MartinaeyNL I covered this change in #58 and made this PR on top of that branch.
I'm still not including the realm in the provision payload, because it is an information we have.
I don't see the use case where a web app loaded in one realm provisions another realm.
The native app still can load the web app under any realm it chooses to, so generic app can switch realm/porject as required.
We can discuss in SU if required.

@ebariaux ebariaux requested a review from MartinaeyNL May 27, 2026 05:29
@ebariaux ebariaux merged commit b8f34ab into main May 27, 2026
1 check passed
@ebariaux ebariaux deleted the fix/provision-provider-realm-api-url branch May 27, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinaeyNL MartinaeyNL MartinaeyNL approved these changes

Assignees

No one assigned

Labels

Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use proper realm when building URL for Provisioning Provider

2 participants

@ebariaux @MartinaeyNL